Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storage/volume types from gp2 to gp3 across all plans #255

Closed
2 tasks
markdboyd opened this issue Oct 12, 2022 · 8 comments
Closed
2 tasks

Update storage/volume types from gp2 to gp3 across all plans #255

markdboyd opened this issue Oct 12, 2022 · 8 comments

Comments

@markdboyd
Copy link
Contributor

markdboyd commented Oct 12, 2022

In order to optimize costs, we should update EBS storage from gp2 to gp3 volumes across all of our brokered plans


Security considerations

There are no meaningful security differences from gp2 to gp3 volumes, as far as I know, just cost and performance optimizations.

https://aws.amazon.com/ebs/general-purpose/#:~:text=gp3%20offers%20SSD%2Dperformance%20at,improving%20performance%20and%20reducing%20costs.

Implementation sketch

  • Update all plans in catalog to use gp3 for storage_type instead of gp2
  • Update all plans in catalog to use gp3 for volumeType instead of gp2
@JasonTheMain
Copy link
Contributor

ill test changing plans and start investigating the difference for a little spare fuin

@JasonTheMain
Copy link
Contributor

Following issues are a blocked for now hashicorp/terraform-provider-aws#28271

@JasonTheMain
Copy link
Contributor

fixed issues, pull request for changes are here

@JasonTheMain
Copy link
Contributor

found bugs, will update when working

@JasonTheMain
Copy link
Contributor

hashicorp/terraform-provider-aws#28160 blocked issue for now

@etiennechabert
Copy link

@JasonTheMain you should not have any more blocker to adopt gp3.

If using: https://github.com/terraform-aws-modules/terraform-aws-rds use the last version:
https://github.com/terraform-aws-modules/terraform-aws-rds/releases/tag/v5.2.2

Default values have been fixed, allowing a smooth transition to gp3.

@markdboyd
Copy link
Contributor Author

Closing this and opening #271 to handle converting existing databases to gp3

@markdboyd markdboyd reopened this Jan 25, 2023
@markdboyd markdboyd assigned Ephraim-G and unassigned JasonTheMain Sep 5, 2023
@markdboyd markdboyd changed the title Update storage from gp2 to gp3 across all plans Update storage/volume types from gp2 to gp3 across all plans Sep 5, 2023
@Ephraim-G
Copy link

closed per #330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants