Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py should throw a helpful error if run on Python 2.x #35

Open
toolness opened this issue Jun 28, 2017 · 2 comments
Open

setup.py should throw a helpful error if run on Python 2.x #35

toolness opened this issue Jun 28, 2017 · 2 comments

Comments

@toolness
Copy link
Contributor

toolness commented Jun 28, 2017

Ugh, was trying to deploy the bug bounty dashboard to cloud.gov and ran into this:

       Collecting cg-django-uaa==1.1.0 (from -r requirements.txt (line 11))
         Downloading cg-django-uaa-1.1.0.tar.gz (1.3MB)
           Complete output from command python setup.py egg_info:
           Traceback (most recent call last):
             File "<string>", line 1, in <module>
             File "/tmp/pip-build-RTvV4h/cg-django-uaa/setup.py", line 92, in <module>
               long_description=open('README.rst', 'r', encoding='utf-8').read(),
           TypeError: 'encoding' is an invalid keyword argument for this function

I am guessing this may be because it is running setup.py with python 2.7?

@toolness
Copy link
Contributor Author

Oh, I forgot to add a runtime.txt with python-3.6.1 in it, that might fix it.

@toolness
Copy link
Contributor Author

Yup, that fixed it! That said, it might be good to have setup.py raise a more friendly error if the user runs it with Python 2.x.

@toolness toolness changed the title setup.py fails to load on cloudfoundry setup.py should throw a helpful error if run on Python 2.x Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant