Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting errorcachingminttl on cdns #228

Open
bengerman13 opened this issue Dec 29, 2021 · 2 comments
Open

Support setting errorcachingminttl on cdns #228

bengerman13 opened this issue Dec 29, 2021 · 2 comments

Comments

@bengerman13
Copy link
Contributor

We should support setting ErrorCachingMinTTL on cdn instances. Once we do this, we need to update the migrator to parse and update the config (This should also support distributions where ResponseCode is empty string and ErrorCode is an int)

When we write this, we need to write an alembic migration to backport the existing mincachingttl to distributions that have it configured.

@markdboyd
Copy link
Contributor

@bengerman13 Was this a customer request? If not, can we close and deprioritize pending a customer request?

@bengerman13
Copy link
Contributor Author

I think this was thought to be broadly interesting to customers, especially Pages users, to prevent cache poisoning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants