Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fastapi dependency optional #330

Open
dariogoetz opened this issue Jan 29, 2025 · 0 comments
Open

Make fastapi dependency optional #330

dariogoetz opened this issue Jan 29, 2025 · 0 comments

Comments

@dariogoetz
Copy link

dariogoetz commented Jan 29, 2025

Describe why it is important and where it will be useful

The fastapi dependency is only necessary when implementing an "app", i.e. using NextCloudApp or AsyncNextCloudApp. If one is only interested in using the nextcloud API, i.e. NextCloud and AsyncNextCloud, the fastapi dependency is simply "dead weight" (in my specific case, it generated a version conflict because I need to use an older version of fastapi for some reason).

Describe your proposed solution

Is it possible to make fastapi an optional dependency for the app option? This would, however, probably entail moving the NextCloudApp and AsyncNextCloudApp into the ex_app package (which is a breaking change...?).

It would probably also mean that the whole ex_app package could be imported "optionally" (guarded with a try...except block similarly to the uvicorn import in the ex_app.uvicorn_fastapi module).

Describe alternatives you've considered, if relevant

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant