From bff209d853ae081ec692c41a080071956bf4ae2d Mon Sep 17 00:00:00 2001 From: Berat BAYRAM Date: Mon, 10 Feb 2025 18:58:57 +0300 Subject: [PATCH] [create-cloudflare] next.js with ts fix (#7854) * resolves #925 * fixes issue name * fix(create-cloudflare): update version from major to patch * Revert last 3 commits * fix(create-cloudflare): removed top-level await in next.config.ts * fix(create-cloudflare): typo fix * fix(create-cloudflare): changeset fix * fix(create-cloudflare): Update .changeset/famous-coats-admire.md Co-authored-by: Victor Berchet * fix(create-cloudflare): Update .changeset/famous-coats-admire.md 2 * fix(create-cloudflare): Update .changeset/famous-coats-admire.md 3 Co-authored-by: Victor Berchet * fix(create-cloudflare): pnpm fix on changeset --------- Co-authored-by: Berat BAYRAM Co-authored-by: Victor Berchet Co-authored-by: Carmen Popoviciu --- .changeset/famous-coats-admire.md | 8 ++++++++ packages/create-cloudflare/templates/next/c3.ts | 10 +++++----- 2 files changed, 13 insertions(+), 5 deletions(-) create mode 100644 .changeset/famous-coats-admire.md diff --git a/.changeset/famous-coats-admire.md b/.changeset/famous-coats-admire.md new file mode 100644 index 000000000000..862a5ba2098c --- /dev/null +++ b/.changeset/famous-coats-admire.md @@ -0,0 +1,8 @@ +--- +"create-cloudflare": patch +--- + +Update the Next.js template + +- Removed top-level `await` in `next.config.ts` as it is not allowed there and not required. +- Improved `setupDevPlatform()` comment diff --git a/packages/create-cloudflare/templates/next/c3.ts b/packages/create-cloudflare/templates/next/c3.ts index 4202bf280a70..a03bdc14d3da 100644 --- a/packages/create-cloudflare/templates/next/c3.ts +++ b/packages/create-cloudflare/templates/next/c3.ts @@ -42,12 +42,12 @@ const updateNextConfig = (usesTs: boolean) => { const updatedConfigFile = `import { setupDevPlatform } from '@cloudflare/next-on-pages/next-dev'; - // Here we use the @cloudflare/next-on-pages next-dev module to allow us to use bindings during local development - // (when running the application with \`next dev\`), for more information see: + // Here we use the @cloudflare/next-on-pages next-dev module to allow us to + // use bindings during local development (when running the application with + // \`next dev\`). This function is only necessary during development and + // has no impact outside of that. For more information see: // https://github.com/cloudflare/next-on-pages/blob/main/internal-packages/next-dev/README.md - if (process.env.NODE_ENV === 'development') { - await setupDevPlatform(); - } + setupDevPlatform().catch(console.error); `.replace(/\n\t*/g, "\n") + configContent;