Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect sensitivity for some of the attributes on the provider block #54

Closed
1 task done
v0lkc opened this issue Oct 31, 2024 · 1 comment · Fixed by #61
Closed
1 task done

[BUG] Incorrect sensitivity for some of the attributes on the provider block #54

v0lkc opened this issue Oct 31, 2024 · 1 comment · Fixed by #61
Labels
bug Something isn't working

Comments

@v0lkc
Copy link

v0lkc commented Oct 31, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What version of the Terraform provider are you using?

1.0.0

What version of the Terraform CLI are you using?

1.7.0

What CF API version are you using?

No response

What type of issue are you facing

bug report

Describe the bug

In the provider block, the sensitivity is incorrectly set for some attributes, potentially exposing sensitive information. The following issues have been identified:

Attributes that should be marked as sensitive:

  • access_token (String): OAuth token to authenticate with Cloud Foundry
  • refresh_token (String): Token to refresh the access token, requires access_token

Attributes that are incorrectly marked as sensitive:

  • cf_client_id (String, Sensitive): Unique identifier for a client application used in authentication and authorization processes
  • user (String, Sensitive): A unique identifier associated with an individual or entity for authentication & authorization purposes.

Expected Behavior

No response

Steps To Reproduce

No response

Your Terraform Configuration

No response

Roles

No response

Add screenshots to help explain your problem

No response

Additional context

No response

@v0lkc v0lkc added the bug Something isn't working label Oct 31, 2024
@v0lkc v0lkc changed the title [BUG] [BUG] Incorrect sensitivity for some of the attributes on the provider block Oct 31, 2024
@vipinvkmenon
Copy link
Member

hI @v0lkc ,

Thanks for that feedback :) and very valid.
A PR to fix it is on the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants