Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] License Section pointing to SAP #64

Closed
1 task done
lechnerc77 opened this issue Nov 6, 2024 · 1 comment · Fixed by #68
Closed
1 task done

[BUG] License Section pointing to SAP #64

lechnerc77 opened this issue Nov 6, 2024 · 1 comment · Fixed by #68
Labels
bug Something isn't working

Comments

@lechnerc77
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What version of the Terraform provider are you using?

all

What version of the Terraform CLI are you using?

1.9.5

What CF API version are you using?

n/a

What type of issue are you facing

documentation issue

Describe the bug

The "License" section in the README.md still points to SAP (https://github.com/cloudfoundry/terraform-provider-cloudfoundry?tab=readme-ov-file#licensing). However the provider is now under the CF Foundation and this should be reflected in this section.

Expected Behavior

License statement reflects the ownership of CF foundation

Steps To Reproduce

n/a

Your Terraform Configuration

n/a

Roles

n/a

Add screenshots to help explain your problem

n/a

Additional context

n/a

@lechnerc77 lechnerc77 added the bug Something isn't working label Nov 6, 2024
@v0lkc
Copy link

v0lkc commented Nov 6, 2024

It's not only the license statement, but there are also plenty of other references which I think should be removed or updated. Just to give you some examples:

https://github.com/search?q=repo%3Acloudfoundry%2Fterraform-provider-cloudfoundry%20sap&type=code

vipinvkmenon added a commit that referenced this issue Nov 7, 2024
Remove SAP references from migration guide
Remove SAP references from README, CONTRIBUTING & DEVELOPER docs
Update sonar cloud references
closes #64
vipinvkmenon added a commit that referenced this issue Nov 8, 2024
Remove SAP references from migration guide
Remove SAP references from README, CONTRIBUTING & DEVELOPER docs
Update sonar cloud references
closes #64
@Dray56 Dray56 closed this as completed in #68 Nov 8, 2024
@Dray56 Dray56 closed this as completed in a34b3cc Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants