Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove async_trait dependency #1997

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

carneiro-cw
Copy link
Contributor

@carneiro-cw carneiro-cw commented Jan 31, 2025

PR Type

Other


Description

  • Remove unused async-trait dependency from Cargo.toml

Changes walkthrough 📝

Relevant files
Dependencies
Cargo.toml
Remove async-trait dependency                                                       

Cargo.toml

  • Removed async-trait = "=0.1.80" from dependencies
+0/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @carneiro-cw carneiro-cw changed the title chore: remove unused ansync_trait dependencies chore: remove unused ansync_trait dependency Jan 31, 2025
    @carneiro-cw carneiro-cw enabled auto-merge (squash) January 31, 2025 18:47
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @carneiro-cw carneiro-cw changed the title chore: remove unused ansync_trait dependency chore: remove unused async_trait dependency Jan 31, 2025
    @carneiro-cw carneiro-cw changed the title chore: remove unused async_trait dependency chore: remove async_trait dependency Jan 31, 2025
    @carneiro-cw carneiro-cw merged commit 507375c into main Jan 31, 2025
    38 checks passed
    @carneiro-cw carneiro-cw deleted the remove_unused_async_trait_deps branch January 31, 2025 21:12
    @gabriel-aranha-cw
    Copy link
    Contributor

    Final benchmark:
    Run ID: bench-3542246664

    Git Info:

    Configuration:

    • Target Account Strategy: Default

    RPS Stats: Max: 1963.00, Min: 886.00, Avg: 1746.47, StdDev: 89.07
    TPS Stats: Max: 1964.00, Min: 1551.00, Avg: 1696.39, StdDev: 90.10

    Plot: View Plot

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants