Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[evaluator] Loading only a slice of the JSON #15

Open
pieterdavid opened this issue Jan 27, 2021 · 1 comment
Open

[evaluator] Loading only a slice of the JSON #15

pieterdavid opened this issue Jan 27, 2021 · 1 comment
Labels
enhancement New feature or request evaluator Issues related to the evaluator

Comments

@pieterdavid
Copy link
Contributor

Related to https://github.com/nsmith-/correctionlib/issues/8 : if many different working points, scalefactor types, JEC levels etc. end up being put in the same JSON, it would be very useful for the evaluator if the evaluator would only load the parts that are needed (e.g. for b-tagging only loose WP, or only light jet mistag for the loose WP).

@nsmith-
Copy link
Collaborator

nsmith- commented Feb 10, 2021

I had some plan to provide a pure python command-line tool to manipulate the json, allowing to slice various dimensions or remove a subset of corrections. For the evaluator, I am a bit reluctant to provide too much customization, but at least it seems straightfoward to have an alternative factory to https://github.com/nsmith-/correctionlib/blob/c3710d48bb0dca6334bf03c41b79130f09c925fb/include/correction.h#L152-L153 that takes a list of correction names to load, skipping others present in the file. More fine-grained control seems better left to the pure python tool, since it is easier to develop.

@nsmith- nsmith- added the enhancement New feature or request label Feb 16, 2021
@nsmith- nsmith- added the evaluator Issues related to the evaluator label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request evaluator Issues related to the evaluator
Development

No branches or pull requests

2 participants