Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ interface for providing columns by name #166

Open
alexander-held opened this issue Feb 8, 2023 · 3 comments
Open

C++ interface for providing columns by name #166

alexander-held opened this issue Feb 8, 2023 · 3 comments
Labels
enhancement New feature or request evaluator Issues related to the evaluator good first issue Good for newcomers

Comments

@alexander-held
Copy link

Similarly to the possibility to hand over dictionaries that specify column names in the Python API, it would be useful to have support for maps or a compile-time solution that allows doing this in C++. This helps mitigate issues where columns are handed over in the wrong order.

@nsmith- nsmith- added enhancement New feature or request evaluator Issues related to the evaluator labels Feb 10, 2023
@nsmith-
Copy link
Collaborator

nsmith- commented Feb 10, 2023

A partial implementation was discussed also in #8 (comment)

@nsmith- nsmith- added the good first issue Good for newcomers label Mar 16, 2023
@andrzejnovak andrzejnovak moved this to 👷 HaCATthon in DPROC Projects Mar 29, 2023
@andrzejnovak andrzejnovak moved this from 👷 HaCATthon to CAT-Affiliated in DPROC Projects Mar 30, 2023
@nsmith-
Copy link
Collaborator

nsmith- commented May 2, 2023

Somewhat surprising, the python highlevel correction does not accept keyword arguments, even though it would be a trivial addition:

def evaluate(
self, *args: Union["numpy.ndarray[Any, Any]", str, int, float]
) -> Union[float, "numpy.ndarray[Any, numpy.dtype[numpy.float64]]"]:

@eguiraud
Copy link
Contributor

Similarly to the possibility to hand over dictionaries that specify column names in the Python API

That's not a thing, right? As per Nick's message above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request evaluator Issues related to the evaluator good first issue Good for newcomers
Development

No branches or pull requests

3 participants