Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two little things on summaries #120

Open
mjohnson11 opened this issue Mar 4, 2023 · 2 comments
Open

Two little things on summaries #120

mjohnson11 opened this issue Mar 4, 2023 · 2 comments
Labels
feature new feature

Comments

@mjohnson11
Copy link

Screen Shot 2023-03-03 at 9 15 42 PM

1 - "entires -> entries"
2 - I interpret "unique entries" to mean singletons (i.e. values that only appear in one row). This instead reports the number of unique values in the column. Since that value is also given up at the top before the summary, I think singletons would be more useful here (and the "XX out of XX non-null rows" makes it seem like maybe this is what you were going for too?)

@mjohnson11 mjohnson11 added the feature new feature label Mar 4, 2023
@willeppy
Copy link
Member

willeppy commented Mar 6, 2023

Thanks for finding spelling error! I think singletons is great idea since youre right this info is a big redundant with the unique values right now.

My code interpretation of a singleton would be all the values where the value_count is exactly 1

@mjohnson11
Copy link
Author

Yeah, that's my interpretation too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature
Projects
None yet
Development

No branches or pull requests

2 participants