Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Drop unneeded HUGO_VERSION from netlify.toml #68

Closed
chalin opened this issue Jul 22, 2021 · 6 comments · Fixed by #96
Closed

Drop unneeded HUGO_VERSION from netlify.toml #68

chalin opened this issue Jul 22, 2021 · 6 comments · Fixed by #96
Assignees

Comments

@chalin
Copy link
Collaborator

chalin commented Jul 22, 2021

Given that this template repo uses the hugo-extended npm package, IMHO we don't need to (actually, shouldn't) specifying a Hugo version in netlify.toml:

[build.environment]
HUGO_VERSION = "0.75.1"

Let's keep things DRY and configure the required Hugo version in only one place.

Related: #66

@kapunahelewong
Copy link
Contributor

I can take this one. Is the task to remove just those two lines from netlify.toml?

@kapunahelewong kapunahelewong self-assigned this Jul 23, 2021
@chalin
Copy link
Collaborator Author

chalin commented Jul 23, 2021

Actually, let me test something first before we start on this.

@chalin
Copy link
Collaborator Author

chalin commented Jul 23, 2021

Check complete: I wanted to ensure that there weren't going to be any problems with running the npm-fetched Hugo under macOS 10.15+. There are not permissions issues.

I can take this one.

Thanks!

Is the task to remove just those two lines from netlify.toml?

And anywhere else that a Hugo version might be mentioned -- e.g., the README file.

@chalin
Copy link
Collaborator Author

chalin commented Jul 23, 2021

You might want to tackle #66 at the same time, or not. It's your call.

@chalin
Copy link
Collaborator Author

chalin commented Jul 26, 2021

And anywhere else that a Hugo version might be mentioned -- e.g., the README file.

If you just want to update the netlify.toml file for this issue, that'll be fine too.

@chalin
Copy link
Collaborator Author

chalin commented Jul 26, 2021

Oh, I just remembered that if we use the npm-installed version of hugo, then you'll need to update the Makefile to use npx hugo everywhere a plain hugo is currently written.

kapunahelewong added a commit to kapunahelewong/hugo-netlify-starter that referenced this issue Jul 26, 2021
kapunahelewong added a commit to kapunahelewong/hugo-netlify-starter that referenced this issue Jul 26, 2021
Fixes cncf#68

Signed-off-by: Kapunahele Wong <[email protected]>
kapunahelewong added a commit to kapunahelewong/hugo-netlify-starter that referenced this issue Jul 26, 2021
Fixes cncf#68

Signed-off-by: Kapunahele Wong <[email protected]>
nate-double-u pushed a commit that referenced this issue Jul 26, 2021
Fixes #68

Signed-off-by: Kapunahele Wong <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants