Skip to content
This repository has been archived by the owner on Jun 29, 2019. It is now read-only.

Lessons from the workshop #3

Open
8 tasks
D4nte opened this issue Jun 19, 2019 · 2 comments
Open
8 tasks

Lessons from the workshop #3

D4nte opened this issue Jun 19, 2019 · 2 comments
Assignees

Comments

@D4nte
Copy link
Contributor

D4nte commented Jun 19, 2019

Lessons from the workshop:

  • It works!
  • comit-i is easy to use
  • It is hard to create a dev Ethereum network with parity
  • It is easy to create a regtest Bitcoin network with bitcoind
  • bitcoind commandline is not that user friendly but ok
  • Links works but people are surprised that other can change the rates in link
    • Follow-up on link-id discussion so that for a given link-id bobtimus/comit-i reject a swap if details are different?
  • It gets confusing when there is a lot of swap
  • Rust developers may not have nightly. see Compile on stable Rust! comit-network/comit-rs#1047
  • Despite node setup, Rust compilation was the most challenging
  • People prefer BTC/Ether to Sat/Wei: see Display main asset unit in UI comit-network/comit-i#95
  • Link is too long
  • Alpha/Beta wording is confusing, especially when accepting/declining a swap. Is Clearer sell/buy comit-network/comit-i#97 enough?
  • Fund/Refund/Redeem terms are confusing, proposed terms are Send/Cancel/Receive
  • People loved hands on format -> Ok refund makes sense. but Lock makes more sense than Fund
  • remove web+comit from link
  • Make it a game/competition next time
  • Do a wrap-up with open questions next time
  • Implement auto-refresh or websocket
@D4nte D4nte self-assigned this Jun 19, 2019
@da-kami
Copy link
Contributor

da-kami commented Jun 20, 2019

Fund/Refund/Redeem terms are confusing, proposed terms are Send/Cancel/Receive
People loved hands on format -> Ok refund makes sense. but Lock makes more sense than Fund

my thoughts:

Fund -> Send 😒 - Send is too general and already used to send the swap request
Fund -> Fund 😀 - I like Fund
Fund -> Lock 😐 - I find Fund better, but am OK with Lock
Fund -> Lock Funds 😀
Refund -> Chancel 😒 - too general
Refund -> Revert 😐- would be OK for me
Redeem -> Receive 😀 - I like that, am not exactly happy with Redeem

Note:
in the RFCs that define the implementation (e.g. https://github.com/comit-network/RFCs/blob/master/RFC-005-SWAP-Basic-Bitcoin.md) we actually call the Fund stage Deployment.

@thomaseizinger
Copy link
Contributor

I could live with Lock Funds :)

Suggestions for Redeem (possible concatenated with Funds, same as for Lock Funds):

  • Withdraw
  • Claim
  • Extract
  • Unlock
  • Take

Since the name of the action is returned by the comit node, we could even make the action name be specific to the asset:

For Alpha:

  1. Fund -> Lock Bitcoin
  2. Redeem -> Take Ether
  3. Refund -> Take Bitcoin back

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants