Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: rename min_checkpoint_frequency option #138670

Open
andyyang890 opened this issue Jan 8, 2025 · 1 comment
Open

changefeedccl: rename min_checkpoint_frequency option #138670

andyyang890 opened this issue Jan 8, 2025 · 1 comment
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc

Comments

@andyyang890
Copy link
Collaborator

andyyang890 commented Jan 8, 2025

We should consider renaming the min_checkpoint_frequency option since its name could be misleading. It doesn't control how frequently the changefeed checkpoints but rather how frequently a change aggregator flushes its progress to the change frontier.

checkpointFrontier := advanced &&
(forceFlush || timeutil.Now().After(ca.nextHighWaterFlush))
if checkpointFrontier {
defer func() {
ca.nextHighWaterFlush, err = nextFlushWithJitter(
timeutil.DefaultTimeSource{}, ca.flushFrequency, aggregatorFlushJitter.Get(sv))
if err != nil {
returnErr = errors.CombineErrors(returnErr, err)
}
}()
return ca.flushFrontier()
}

Jira issue: CRDB-46299

@andyyang890 andyyang890 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cdc Change Data Capture T-cdc labels Jan 8, 2025
Copy link

blathers-crl bot commented Jan 8, 2025

cc @cockroachdb/cdc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc
Projects
None yet
Development

No branches or pull requests

1 participant