Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache: setting an existing cold entry should make it hot #4178

Open
sumeerbhola opened this issue Nov 21, 2024 · 0 comments
Open

cache: setting an existing cold entry should make it hot #4178

sumeerbhola opened this issue Nov 21, 2024 · 0 comments

Comments

@sumeerbhola
Copy link
Collaborator

sumeerbhola commented Nov 21, 2024

See comment in #4157

// TODO(sumeer): unclear why we don't set e.ptype to etHot on this path.
// In the default case below, where the state is etTest we set it to
// etHot. But etTest is "colder" than etCold, since the only transition
// into etTest is etCold => etTest, so since etTest transitions to
// etHot, then etCold should also transition.

And @RaduBerinde's response:
I think you're right. The paper says that if the page isn't in the list it is added as cold (the e == nil case) but if it is "the faulted page turns into a hot page and is placed at the head of the list".

Jira issue: PEBBLE-308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Incoming
Development

No branches or pull requests

2 participants