Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signup error #229

Open
rammandadapu opened this issue Apr 11, 2015 · 1 comment
Open

Signup error #229

rammandadapu opened this issue Apr 11, 2015 · 1 comment

Comments

@rammandadapu
Copy link

test
Signup page is creating account without giving Name and Password. It is validating only for Email ID
vipulkanade added a commit to vipulkanade/bizfriendly-web that referenced this issue Apr 11, 2015
@vipulkanade
Resolved Signup error codeforamerica#229
fdf26d0 
Added validation for Email, Password, Name on Sign Up Page.
Now unless all three fields are added, User cannot sign up.
@aksharjoshi
Copy link

Hi,

The issue is actually with the server side response.
When a signup request is made the API
http://app.bizfriend.ly/signup

along with data in the format
name : 'abc',
email : '[email protected]',
password : 'xyz'

And on the server side there is a validation on email. Depending on the value of email a response is generated with a valid 200 code or invalid 401 code and the same response value is displayed on client side with an error or success message.

Similar validations should be done on the fields
name and
password.

and provide the response value accordingly.

@vipulkanade vipulkanade mentioned this issue Apr 12, 2015
Merged
ondrae pushed a commit that referenced this issue Apr 12, 2015
Merge pull request #238 from vipulkanade/gh-pages
ab03d6d 
Resolved error #229 , #244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rammandadapu @aksharjoshi