Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key modifiers are ignored on iPad with hardware keyboard #1343

Closed
nightwing opened this issue Feb 21, 2024 · 1 comment
Closed

Key modifiers are ignored on iPad with hardware keyboard #1343

nightwing opened this issue Feb 21, 2024 · 1 comment

Comments

@nightwing
Copy link

Describe the issue

flushIOSKey when calling dispatchKey discards ctrlKey, metaKey, altKey of pendingIOSKey event, as a result the editor gets notification about d being pressed while user have pressed ctrl-d

replit/codemirror-vim#115

Browser and platform

Safari on IOS

Reproduction link

https://raw.githack.com/replit/codemirror-vim/master/dev/web-demo.html

marijnh added a commit to codemirror/view that referenced this issue Mar 11, 2024
FIX: Fix a bug where, on iOS with a physical keyboard, the modifiers for
some keys weren't being passed to the keymaps.

Issue codemirror/dev#1343
marijnh added a commit to codemirror/view that referenced this issue Mar 11, 2024
FIX: Work around the fact that Mobile Safari makes DOM changes before firing
a key event when typing ctrl-d on an external keyboard.

Issue codemirror/dev#1343
@marijnh
Copy link
Member

marijnh commented Mar 11, 2024

Attached patches should help with this, and work around the fact that, due to buggy event ordering on that browser, the effect of ctrl-d would end up being applied twice (at least with my keyboard/iOS version).

@marijnh marijnh closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants