Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot login the recently created user due to No active account found with the given credentials #52

Open
Mahmoud-Emad opened this issue Aug 15, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@Mahmoud-Emad
Copy link
Collaborator

Description

the user instance was created without hashing the password, so when login by the credentials we see No active account found with the given credentials because the system does compare the actual password string with the hashed password which will return a False

Solution

Hashed the user password before saving it

Changes

  • Imported and used the make_password function to hash the user password
  • Added a condition to validate the password length before hashing it
@Mahmoud-Emad Mahmoud-Emad self-assigned this Aug 15, 2024
@Mahmoud-Emad Mahmoud-Emad moved this to In Progress in test-tracker Aug 15, 2024
@Mahmoud-Emad Mahmoud-Emad added this to the 2.0.0 milestone Aug 15, 2024
@Mahmoud-Emad Mahmoud-Emad moved this from In Progress to Pending review in test-tracker Aug 15, 2024
@zaelgohary zaelgohary moved this from Pending review to Done in test-tracker Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

1 participant