[Feature request] Support multiple SPR records via environment variable

[veaceslavdoina]

Is your feature request related to a problem? Please describe.
We can't pass multiple SPR records via environment variable CODEX_BOOTSTRAP_NODE.

Describe the solution you'd like
We should be able to pass multiple SPR records via environment variable, because now we can pass just a single one

export CODEX_BOOTSTRAP_NODE=spr:xxx,spr:yyy

codex

Now we get an error

"error":"Incorrect base64 string"

Describe alternatives you've considered
As for now, we can pass multiple SPR records only using CLI options

codex --bootstrap-node=spr:xxx --bootstrap-node=spr:yyy

Additional context
Environment variables is a very useful way to pass configuration, especially when we are using containers.

[AuHau]

This is blocked by the library's support: status-im/nim-confutils#87

[veaceslavdoina]

In oauth2-proxy, they also add a trailing S - Environment variables

[veaceslavdoina]

An example from Geth - it is plural

    --bootnodes value                                                      ($GETH_BOOTNODES)
          Comma separated enode URLs for P2P discovery bootstrap

[veaceslavdoina]

One more note about how Codex and Geth handle bootstrap env variable

• With Geth we can set docker-compose.yaml and pass GETH_BOOTNODES variable, even if it is empty - Geth will ignore it and start normally.
• Codex will fail to start when CODEX_BOOTSTRAP_NODE variable is empty.

This is important because docker compose does not provide dynamic elements configuration and a single way to pass bootstrap nodes dynamically would be to use command: ${COMMAND} and compute it dynamically and this adds unnecessary logic.

details

Empty value

Geth - Run successfully

docker run --rm -e "GETH_BOOTNODES=" ethereum/client-go:alltools-v1.13.5 geth --verbosity=5


INFO [12-10|17:08:30.461] Config environment variable found        envvar=GETH_BOOTNODES

Codex - Failed to start

docker run --rm -e "CODEX_BOOTSTRAP_NODE=" codexstorage/nim-codex:latest codex --log-level=debug


[Chronicles] Log message not delivered: [Chronicles] A writer was not configured for a dynamic log output device. Log message not delivered: WRN 2023-12-10 17:09:34.941+00:00 Invalid SignedPeerRecord uri               tid=1 uri=

[Chronicles] Log message not delivered: [Chronicles] A writer was not configured for a dynamic log output device. Log message not delivered: {"lvl":"WRN","ts":"2023-12-10 17:09:34.941+00:00","msg":"Invalid SignedPeerRecord uri","tid":1,"uri":""}

[Chronicles] Log message not delivered: [Chronicles] A writer was not configured for a dynamic log output device. Log message not delivered: WRN 2023-12-10 17:09:34.941+00:00 Invalid SignedPeerRecord uri               tid=1 uri=

Wrong value

Geth - Failed to start

docker run --rm -e "GETH_BOOTNODES=text" ethereum/client-go:alltools-v1.13.5 geth --verbosity=5

INFO [12-10|17:12:11.439] Config environment variable found        envvar=GETH_BOOTNODES
INFO [12-10|17:12:11.450] Starting Geth on Ethereum mainnet...
INFO [12-10|17:12:11.451] Bumping default cache on mainnet         provided=1024 updated=4096
CRIT [12-10|17:12:11.452] Bootstrap URL invalid                    enode=text err="missing 'enr:' prefix for base64-encoded record"

Codex - Failed to start

docker run --rm -e "CODEX_BOOTSTRAP_NODE=text" codexstorage/nim-codex:latest codex --log-level=debug


[Chronicles] Log message not delivered: [Chronicles] A writer was not configured for a dynamic log output device. Log message not delivered: WRN 2023-12-10 17:13:47.099+00:00 Invalid SignedPeerRecord uri               tid=1 uri=text

[Chronicles] Log message not delivered: [Chronicles] A writer was not configured for a dynamic log output device. Log message not delivered: {"lvl":"WRN","ts":"2023-12-10 17:13:47.099+00:00","msg":"Invalid SignedPeerRecord uri","tid":1,"uri":"text"}

[Chronicles] Log message not delivered: [Chronicles] A writer was not configured for a dynamic log output device. Log message not delivered: WRN 2023-12-10 17:13:47.099+00:00 Invalid SignedPeerRecord uri               tid=1 uri=text

[veaceslavdoina]

Same issue is with CODEX_LISTEN_ADDRS / --listen-addrs

docker run --rm -e 'CODEX_LOG_LEVEL=trace' -e 'CODEX_LISTEN_ADDRS=/ip4/0.0.0.0/tcp/7777, /ip4/0.0.0.0/tcp/8888' codexstorage/nim-codex

docker run --rm codexstorage/nim-codex codex --log-level=trace --listen-addrs='/ip4/0.0.0.0/tcp/7777, /ip4/0.0.0.0/tcp/8888'

[dryajov]

this isn't how you pass multiple values to codex, you need to repeat the option as many times as required - --listen-addrs='/ip4/0.0.0.0/tcp/7777' --listen-addrs='/ip4/0.0.0.0/tcp/8888'