Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem IE11 #8

Open
jripa opened this issue May 31, 2018 · 3 comments
Open

Problem IE11 #8

jripa opened this issue May 31, 2018 · 3 comments

Comments

@jripa
Copy link

jripa commented May 31, 2018

IE 11 have Problems take a forEach method on NodeList. Resolve them by add this to main.js

    function NodeListToArray(nl) {
          for(var a=[], l=nl.length; l--; a[l]=nl[l]);
         return a;
     }

and
var items = menuEl.querySelectorAll('.menu__item');
items = Array.isArray(items) ? items : NodeListToArray(items);

		items.forEach(function(itemEl, iPos) { ...

and

                   var links = menuEl.querySelectorAll('.menu__link');
                    **links = Array.isArray(links) ? links : NodeListToArray(links);**
                    
		links.forEach(function(linkEl, lPos) {
rejas added a commit to rejas/multilevelmenu that referenced this issue Jun 1, 2018
@rejas
Copy link

rejas commented Jun 1, 2018

Hi @jripa thx for the bug report. I only maintain a fork of this repo over at https://github.com/rejas/multilevelmenu, but I added a fix for IE 11 in there if you want to check it out.

@bryanyong98
Copy link

Hi @rejas, i too have an issue regarding opening this menu on IE11. The menu items won't display in IE at all. Here's the picture of my menu and my IE 11 version.
proof-pic
IE

@rejas
Copy link

rejas commented Feb 7, 2020

hey @bryanyong98 I dont actively maintain or use my fork anymore. Feel free to use it on your own risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants