From b006dddaf33b4f69ae874f1faee275bcbccfffd8 Mon Sep 17 00:00:00 2001 From: Ryan Gilbert Date: Tue, 4 Feb 2025 12:49:32 -0500 Subject: [PATCH] chore: add format check to typescript packages (#254) --- .github/workflows/lint.yml | 9 ++++----- package.json | 4 ++-- .../examples/langchain-cdp-chatbot/.prettierignore | 7 +++++++ typescript/examples/langchain-cdp-chatbot/.prettierrc | 11 +++++++++++ .../examples/langchain-cdp-chatbot/package.json | 6 +++--- .../langchain-farcaster-chatbot/.prettierignore | 7 +++++++ .../examples/langchain-farcaster-chatbot/.prettierrc | 11 +++++++++++ .../examples/langchain-farcaster-chatbot/package.json | 4 ++-- .../langchain-twitter-chatbot/.prettierignore | 7 +++++++ .../examples/langchain-twitter-chatbot/.prettierrc | 11 +++++++++++ .../examples/langchain-twitter-chatbot/package.json | 4 ++-- .../framework-extensions/langchain/package.json | 4 +++- 12 files changed, 70 insertions(+), 15 deletions(-) create mode 100644 typescript/examples/langchain-cdp-chatbot/.prettierignore create mode 100644 typescript/examples/langchain-cdp-chatbot/.prettierrc create mode 100644 typescript/examples/langchain-farcaster-chatbot/.prettierignore create mode 100644 typescript/examples/langchain-farcaster-chatbot/.prettierrc create mode 100644 typescript/examples/langchain-twitter-chatbot/.prettierignore create mode 100644 typescript/examples/langchain-twitter-chatbot/.prettierrc diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index b6ca6398a..f4f6ee281 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -104,7 +104,7 @@ jobs: - name: Run linters run: poetry run make lint - lint-agentkit-typescript: + lint-typescript: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 @@ -114,9 +114,8 @@ jobs: cache: "npm" # Install dependencies in parent directory first - run: npm install - # Then install and lint in working directory - - name: Install and lint AgentKit + # formatting/lint in working directory + - name: Check formatting/lint run: | - npm install + npm run format:check npm run lint - npm run format diff --git a/package.json b/package.json index bdab8b048..ce3c2231a 100644 --- a/package.json +++ b/package.json @@ -16,8 +16,8 @@ "clean": "turbo run clean", "docs": "turbo run docs", "dev": "turbo run dev", - "format": "prettier -c .prettierrc --write \"**/*.{ts,js,cjs,json,md}\"", - "format:check": "prettier -c .prettierrc --check \"**/*.{ts,js,cjs,json,md}\"", + "format": "turbo run format", + "format:check": "turbo run format:check", "lint:fix": "turbo run lint:fix", "test:types": "turbo run test:types" }, diff --git a/typescript/examples/langchain-cdp-chatbot/.prettierignore b/typescript/examples/langchain-cdp-chatbot/.prettierignore new file mode 100644 index 000000000..20de531f4 --- /dev/null +++ b/typescript/examples/langchain-cdp-chatbot/.prettierignore @@ -0,0 +1,7 @@ +docs/ +dist/ +coverage/ +.github/ +src/client +**/**/*.json +*.md diff --git a/typescript/examples/langchain-cdp-chatbot/.prettierrc b/typescript/examples/langchain-cdp-chatbot/.prettierrc new file mode 100644 index 000000000..ffb416b74 --- /dev/null +++ b/typescript/examples/langchain-cdp-chatbot/.prettierrc @@ -0,0 +1,11 @@ +{ + "tabWidth": 2, + "useTabs": false, + "semi": true, + "singleQuote": false, + "trailingComma": "all", + "bracketSpacing": true, + "arrowParens": "avoid", + "printWidth": 100, + "proseWrap": "never" +} diff --git a/typescript/examples/langchain-cdp-chatbot/package.json b/typescript/examples/langchain-cdp-chatbot/package.json index 1f2d88b91..fb509e2d0 100644 --- a/typescript/examples/langchain-cdp-chatbot/package.json +++ b/typescript/examples/langchain-cdp-chatbot/package.json @@ -8,9 +8,9 @@ "start": "NODE_OPTIONS='--no-warnings' ts-node ./chatbot.ts", "dev": "nodemon ./chatbot.ts", "lint": "eslint -c .eslintrc.json *.ts", - "lint-fix": "eslint -c .eslintrc.json *.ts --fix", - "format": "prettier -c .prettierrc --write \"**/*.{ts,js,cjs,json,md}\"", - "format-check": "prettier -c .prettierrc --check \"**/*.{ts,js,cjs,json,md}\"" + "lint:fix": "eslint -c .eslintrc.json *.ts --fix", + "format": "prettier --write \"**/*.{ts,js,cjs,json,md}\"", + "format:check": "prettier -c .prettierrc --check \"**/*.{ts,js,cjs,json,md}\"" }, "dependencies": { "@coinbase/agentkit": "^0.1.0", diff --git a/typescript/examples/langchain-farcaster-chatbot/.prettierignore b/typescript/examples/langchain-farcaster-chatbot/.prettierignore new file mode 100644 index 000000000..20de531f4 --- /dev/null +++ b/typescript/examples/langchain-farcaster-chatbot/.prettierignore @@ -0,0 +1,7 @@ +docs/ +dist/ +coverage/ +.github/ +src/client +**/**/*.json +*.md diff --git a/typescript/examples/langchain-farcaster-chatbot/.prettierrc b/typescript/examples/langchain-farcaster-chatbot/.prettierrc new file mode 100644 index 000000000..ffb416b74 --- /dev/null +++ b/typescript/examples/langchain-farcaster-chatbot/.prettierrc @@ -0,0 +1,11 @@ +{ + "tabWidth": 2, + "useTabs": false, + "semi": true, + "singleQuote": false, + "trailingComma": "all", + "bracketSpacing": true, + "arrowParens": "avoid", + "printWidth": 100, + "proseWrap": "never" +} diff --git a/typescript/examples/langchain-farcaster-chatbot/package.json b/typescript/examples/langchain-farcaster-chatbot/package.json index ecd04c217..d90d4301e 100644 --- a/typescript/examples/langchain-farcaster-chatbot/package.json +++ b/typescript/examples/langchain-farcaster-chatbot/package.json @@ -7,9 +7,9 @@ "start": "NODE_OPTIONS='--no-warnings' ts-node ./chatbot.ts", "dev": "nodemon ./chatbot.ts", "lint": "eslint -c .eslintrc.json *.ts", - "lint-fix": "eslint -c .eslintrc.json *.ts --fix", + "lint:fix": "eslint -c .eslintrc.json *.ts --fix", "format": "prettier -c .prettierrc --write \"**/*.{ts,js,cjs,json,md}\"", - "format-check": "prettier -c .prettierrc --check \"**/*.{ts,js,cjs,json,md}\"" + "format:check": "prettier -c .prettierrc --check \"**/*.{ts,js,cjs,json,md}\"" }, "dependencies": { "@coinbase/agentkit": "^0.1.0", diff --git a/typescript/examples/langchain-twitter-chatbot/.prettierignore b/typescript/examples/langchain-twitter-chatbot/.prettierignore new file mode 100644 index 000000000..20de531f4 --- /dev/null +++ b/typescript/examples/langchain-twitter-chatbot/.prettierignore @@ -0,0 +1,7 @@ +docs/ +dist/ +coverage/ +.github/ +src/client +**/**/*.json +*.md diff --git a/typescript/examples/langchain-twitter-chatbot/.prettierrc b/typescript/examples/langchain-twitter-chatbot/.prettierrc new file mode 100644 index 000000000..ffb416b74 --- /dev/null +++ b/typescript/examples/langchain-twitter-chatbot/.prettierrc @@ -0,0 +1,11 @@ +{ + "tabWidth": 2, + "useTabs": false, + "semi": true, + "singleQuote": false, + "trailingComma": "all", + "bracketSpacing": true, + "arrowParens": "avoid", + "printWidth": 100, + "proseWrap": "never" +} diff --git a/typescript/examples/langchain-twitter-chatbot/package.json b/typescript/examples/langchain-twitter-chatbot/package.json index b98620976..36fa9a0a1 100644 --- a/typescript/examples/langchain-twitter-chatbot/package.json +++ b/typescript/examples/langchain-twitter-chatbot/package.json @@ -8,9 +8,9 @@ "start": "NODE_OPTIONS='--no-warnings' ts-node ./chatbot.ts", "dev": "nodemon ./chatbot.ts", "lint": "eslint -c .eslintrc.json *.ts", - "lint-fix": "eslint -c .eslintrc.json *.ts --fix", + "lint:fix": "eslint -c .eslintrc.json *.ts --fix", "format": "prettier -c .prettierrc --write \"**/*.{ts,js,cjs,json,md}\"", - "format-check": "prettier -c .prettierrc --check \"**/*.{ts,js,cjs,json,md}\"" + "format:check": "prettier -c .prettierrc --check \"**/*.{ts,js,cjs,json,md}\"" }, "dependencies": { "@coinbase/agentkit": "^0.1.0", diff --git a/typescript/framework-extensions/langchain/package.json b/typescript/framework-extensions/langchain/package.json index 3560272f6..8789a6e47 100644 --- a/typescript/framework-extensions/langchain/package.json +++ b/typescript/framework-extensions/langchain/package.json @@ -7,7 +7,9 @@ "license": "Apache-2.0", "main": "dist/index.js", "types": "dist/index.d.ts", - "files": ["dist"], + "files": [ + "dist" + ], "scripts": { "build": "tsc", "lint": "eslint -c .eslintrc.json \"src/**/*.ts\"",