Push 1.1.11 to RubyGems

[zachmargolis]

Hi there,

I'd love to get the changes in 9f8ba47 for Rails compatibility, but it looks like that version has not been pushed to Rubygems.

Is the the currency source? Or is this a clone of the rubyforge version?

Thanks!

[colbygk]

Will do.

[tobijb]

Hey there, when 1.1.11 was pushed it looks like it broke some initializers for the Log4r::Logger?

I'm using the filelog.rb example https://github.com/colbygk/log4r/blob/master/examples/filelog.rb

ruby-1.9.3-p484@test4  ~/Documents/workspace/test4 (master) $ gem uninstall log4r
INFO:  gem "log4r" is not installed
ruby-1.9.3-p484@test4  ~/Documents/workspace/test4 (master) $ gem install log4r --no-ri --no-rdoc --version 1.1.10
Fetching: log4r-1.1.10.gem (100%)
Successfully installed log4r-1.1.10
1 gem installed
ruby-1.9.3-p484@test4  ~/Documents/workspace/test4 (master) $ ruby ./filelog.rb
DEBUG log4r: Added outputter 'stderr' to 'log4r'
DEBUG log4r: Logger 'filelog' set to WARN
ruby-1.9.3-p484@test4  ~/Documents/workspace/test4 (master) $ gem uninstall log4r
Successfully uninstalled log4r-1.1.10
ruby-1.9.3-p484@test4  ~/Documents/workspace/test4 (master) $ gem uninstall log4r
INFO:  gem "log4r" is not installed
ruby-1.9.3-p484@test4  ~/Documents/workspace/test4 (master) $ gem install log4r --no-ri --no-rdoc --version 1.1.11
Fetching: log4r-1.1.11.gem (100%)
Successfully installed log4r-1.1.11
1 gem installed
ruby-1.9.3-p484@test4  ~/Documents/workspace/test4 (master) $ ruby ./filelog.rb
./filelog.rb:5:in `initialize': wrong number of arguments(1 for 0) (ArgumentError)
  from ./filelog.rb:5:in `new'
  from ./filelog.rb:5:in `<main>'
ruby-1.9.3-p484@test4  ~/Documents/workspace/test4 (master) $

[mitchellh]

This really should've been a 1.2 release. Gems are breaking all over the place that follow semantic versioning.

I would appreciate if you'd yank 1.1.11 and push a 1.2.

[patcon]

+1

[aspiers]

I tracked down the #initialize ArgumentError to commit ae798a9 in 1.1.11 which removed the following line from lib/log4r/outputter/outputterfactory.rb:

require "log4r/logger"

This was done to avoid circular require, but unfortunately meant that it is now possible for this module to never be required, therefore in some cases (e.g. running vagrant --help) 1.1.11 failed to define Log4r::Logger#initialize, so Ruby assumed that the constructor required zero arguments. I suspect the correct fix is to add

require "log4r/logger"

to lib/log4r.rb but I would have to check the dependency graph to be sure. I also mentioned this on the rubyforge tracker:

• http://rubyforge.org/tracker/index.php?func=detail&aid=29856&group_id=203&atid=851

[colbygk]

Thanks for finding this,

I’ve been woefully behind on what I want to push out. That’s what 19 credit hours per semester gets you.

I had tracked it down to being something wrong with require’s, but I haven’t run across a dependency tracer for Ruby yet. Do you have any suggestions for one?

Cheers,

• Colby

On Feb 20, 2014, at 9:06 AM, Adam Spiers [email protected] wrote:

I tracked down the #initialize ArgumentError to commit ae798a9 in 1.1.11 which removed the following line from lib/log4r/outputter/outputterfactory.rb:

require "log4r/logger"
This was done to avoid circular require, but unfortunately meant that it is now possible for this module to never be required, therefore in some cases (e.g. running vagrant --help) 1.1.11 failed to define Log4r::Logger#initialize, so Ruby assumed that the constructor required zero arguments. I suspect the correct fix is to add

require "log4r/logger"
to lib/log4r.rb but I would have to check the dependency graph to be sure. I also mentioned this on the rubyforge tracker:

http://rubyforge.org/tracker/index.php?func=detail&aid=29856&group_id=203&atid=851
—
Reply to this email directly or view it on GitHub.

[aspiers]

No I never looked before, but google has a few suggestions including http://depgraph.rubyforge.org/