Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PublishModule not inherit from JavaModule #4338

Open
lihaoyi opened this issue Jan 16, 2025 · 2 comments
Open

Make PublishModule not inherit from JavaModule #4338

lihaoyi opened this issue Jan 16, 2025 · 2 comments
Milestone

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Jan 16, 2025

Similar to what we did for AssemblyModule/RunModule/TestModule. PublishModule should be something you can mix into JavaModule, but can also be used separately if you want to publish artifacts to maven central that already exist and don't need to be compiled on the spot. Mill's mill-dist artifact is an example of this, being an uberjar that doesn't fit into the normal JavaModule framework

@lihaoyi lihaoyi added this to the 0.13.0 milestone Jan 16, 2025
@lefou
Copy link
Member

lefou commented Jan 16, 2025

Does it need to be an CoursierModule at least?

@lihaoyi
Copy link
Member Author

lihaoyi commented Jan 16, 2025

@lefou not sure TBH, but in theory it should be able to define the things it needs as abstract and have them wired up automatically when mixed in with a javamodule or coursiermodule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants