Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POC: Implement the RPC service #3

Closed
Tracked by #825
, #7
...
andynog opened this issue May 11, 2023 · 1 comment
Closed
Tracked by #825
, #7
...

POC: Implement the RPC service #3

andynog opened this issue May 11, 2023 · 1 comment
Assignees
@andynog
Labels
enhancement New feature or request rpc

Comments

@andynog
Copy link
Contributor

andynog commented May 11, 2023 •
edited
Loading

The RPC service exposes the endpoints that serve the requests and can be invoked by RPC clients. The RPC service will retrieve the information from the database and send a response that is equivalent to the one from the full node for the existing CometBFT RPC endpoints

NOTE: For the POC, the RPC service will only expose a REST endpoint. In the future the service should offer a JSONRPC endpoint the same as the full node.
@andynog andynog added enhancement New feature or request rpc labels May 11, 2023
@andynog andynog self-assigned this May 11, 2023
@andynog andynog mentioned this issue May 11, 2023
Closed
3 tasks
andynog added a commit that referenced this issue May 18, 2023
@andynog
initial logic for rpc service (#3)
39065f9
andynog added a commit that referenced this issue May 18, 2023
@andynog
initial logic to return block data (#3)
9c95bec
@andynog andynog mentioned this issue Jun 2, 2023
Merged
andynog added a commit that referenced this issue Jun 2, 2023
@andynog
initial logic to return a duplicate vote evidence (#3)
55960fa
andynog added a commit that referenced this issue Jun 2, 2023
@andynog
fully implemented the duplicate vote evidence response (#3)
c493351
andynog added a commit that referenced this issue Jun 7, 2023
@andynog
initial logic to return light client attack evidence (#3)
778f632
andynog added a commit that referenced this issue Jun 19, 2023
@andynog
initial service commands implementation #1 #3
f1c4876
@andynog andynog changed the title Implement the RPC service POC: Implement the RPC service Jun 20, 2023
@andynog andynog mentioned this issue Jun 20, 2023
Closed
4 tasks
andynog added a commit that referenced this issue Jun 20, 2023
@andynog
implemented RPC as a service (#3)
3c9a97a
andynog added a commit that referenced this issue Jun 21, 2023
@andynog
fixed logic to return proper json using CometBFT libs/json (#3)
4a8c39b
andynog added a commit that referenced this issue Jun 23, 2023
@andynog
minor refactoring (#3)
eefe263
andynog added a commit that referenced this issue Jun 27, 2023
@andynog
added byzantine validators return in light client attack evidence (#3)
56c676a
@andynog
Copy link
Contributor Author

andynog commented Jun 28, 2023

this was implemented as part of the PR #6 that was just merged

@andynog andynog closed this as completed Jun 28, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in CometBFT 2023 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andynog andynog

Labels
enhancement New feature or request rpc
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andynog