From e2bea4f93a70fcfa46f9913363eae61bfaa71c5d Mon Sep 17 00:00:00 2001 From: Michael Witten Date: Fri, 8 Mar 2024 18:04:01 +0000 Subject: [PATCH] build: Remove unnecessary enabling of target property: MACOSX_RPATH According to CMake's documentation, MACOSX_RPATH is on already: https://cmake.org/cmake/help/latest/policy/CMP0042.html Specifically: CMake 3.0 and later prefer this property to be ON by default. [This policy] may be set by cmake_policy() or cmake_minimum_required(). If it is not set, CMake warns, and uses OLD behavior. Well, the top-level 'CMakeLists.txt' already sets the minimum version: cmake_minimum_required(VERSION 3.7) Therefore, it is unnecessary to enable it explicitly. --- src/CMakeLists.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 82bdc04e6..d98a4079e 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -28,7 +28,6 @@ add_library(cmark xml.c) cmark_add_compile_options(cmark) set_target_properties(cmark PROPERTIES - MACOSX_RPATH TRUE OUTPUT_NAME "cmark" # Avoid name clash between PROGRAM and LIBRARY pdb files. PDB_NAME libcmark