From bea484d9f4c7c0154d553ec794a3ee98df17d478 Mon Sep 17 00:00:00 2001 From: brgcode Date: Thu, 22 Sep 2022 09:52:47 +0200 Subject: [PATCH 1/2] change to non-zero precision --- CHANGELOG.md | 4 ++-- src/compas_rhino/conversions/cylinder.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 43f79f91a807..fcfe573f9f42 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,17 +12,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 * Added `GLTFContent.check_extensions_texture_recursively` * Added `GLTFContent.get_node_by_name`, `GLTFContent.get_material_index_by_name` * Added `GLTFContent.add_material`, `GLTFContent.add_texture`, `GLTFContent.add_image` - * Added pluggable `Brep` support with `compas.geometry.brep`. * Added Rhino `Brep` plugin in `compas_rhino.geometry.brep`. * Added boolean operations to the `compas_rhino` `Brep` backend. * Added boolean operation operator overloads in `compas.geometry.Brep` ### Changed -* Based all gltf data classes on `BaseGLTFDataClass` +* Based all gltf data classes on `BaseGLTFDataClass` * Fixed `Color.__get___` AttributeError. * Fixed `cylinder_to_rhino` conversion to match `compas.geometry.Cylinder` location. +* Changed identification of cylinder brep face to non-zero in `compas_rhino.conversions.cylinder.Cylinder`. ### Removed diff --git a/src/compas_rhino/conversions/cylinder.py b/src/compas_rhino/conversions/cylinder.py index 9d8f43923ceb..2548d6467c8e 100644 --- a/src/compas_rhino/conversions/cylinder.py +++ b/src/compas_rhino/conversions/cylinder.py @@ -46,7 +46,7 @@ def geometry(self, geometry): faces = geometry.Faces geometry = None for face in faces: - if face.IsCylinder(): + if face.IsCylinder(0.001): result, geometry = face.TryGetFiniteCylinder(0.001) if result: break From a202ca4e56dfb9037963de3165af4f918b3773e3 Mon Sep 17 00:00:00 2001 From: Tom Van Mele Date: Tue, 4 Oct 2022 13:50:14 +0200 Subject: [PATCH 2/2] Update cylinder.py --- src/compas_rhino/conversions/cylinder.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compas_rhino/conversions/cylinder.py b/src/compas_rhino/conversions/cylinder.py index 2548d6467c8e..802920fc3d7b 100644 --- a/src/compas_rhino/conversions/cylinder.py +++ b/src/compas_rhino/conversions/cylinder.py @@ -46,6 +46,9 @@ def geometry(self, geometry): faces = geometry.Faces geometry = None for face in faces: + # being too strict about what is considered a cylinder + # results in cylinders created by Rhino itself + # to not be recognized... if face.IsCylinder(0.001): result, geometry = face.TryGetFiniteCylinder(0.001) if result: