Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt rate_updates to multi-cells #131

Open
cguzman95 opened this issue Nov 2, 2019 · 2 comments
Open

Adapt rate_updates to multi-cells #131

cguzman95 opened this issue Nov 2, 2019 · 2 comments
Assignees

Comments

@cguzman95
Copy link
Collaborator

Mentioned briefly in #125, rxn_data class misses some function to update rxn_solver_id and consequently difference cells (actually, it's set by default to zero and not updated, so when we do update_rata we are going each time to cell 0). I half-fixed it in #129 updating the same rate to all cells, but should be fixed completely in the future.

Since it needs some design on the main fortran code, I want to asign this to you, @mattldawson and avoid some possible re-design of my implementation.

@mattldawson mattldawson self-assigned this Nov 2, 2019
@mattldawson
Copy link
Collaborator

sounds good - I may have some questions as I start working on this

@cguzman95
Copy link
Collaborator Author

cguzman95 commented Nov 2, 2019

Ok no problem. To do a suggestment, I think it should be something like when we create the update_rate object, send as an optional parameter the id cell that we want to set. Then, in the corresponding test create multiple rxn_update_data objects, each one with his own type, rate and cell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants