From 81de9c0ba64bc4fb9f86b672612787ba0b35d6cb Mon Sep 17 00:00:00 2001 From: Balint Gabor <127662+gbalint@users.noreply.github.com> Date: Mon, 15 Jul 2024 15:46:53 +0200 Subject: [PATCH] Early return was wrong --- .../ui-jsx-canvas-component-renderer.tsx | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/editor/src/components/canvas/ui-jsx-canvas-renderer/ui-jsx-canvas-component-renderer.tsx b/editor/src/components/canvas/ui-jsx-canvas-renderer/ui-jsx-canvas-component-renderer.tsx index c7c4deff04ce..463ad0f03d05 100644 --- a/editor/src/components/canvas/ui-jsx-canvas-renderer/ui-jsx-canvas-component-renderer.tsx +++ b/editor/src/components/canvas/ui-jsx-canvas-renderer/ui-jsx-canvas-component-renderer.tsx @@ -387,10 +387,6 @@ function isRenderProp(prop: any): prop is { props: { [UTOPIA_PATH_KEY]: string } } function areElementsInChildrenOrPropsTree(elementPaths: Array, props: any): boolean { - if (props.children == null || typeof props.children === 'string') { - return false - } - const childrenArr = fastReactChildrenToArray(props.children) for (let c of childrenArr) { @@ -420,6 +416,9 @@ function areElementsInChildrenOrPropsTree(elementPaths: Array, props: an } function fastReactChildrenToArray(children: any) { + if (children == null || typeof children === 'string') { + return [] + } if (React.isValidElement(children)) { return [children] }