Fix eslint-plugin-react versions #5073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try me(building...) |
Job #11127: Bundle Size — 63.29MiB (+0.06%).
Important Bundle introduced 1 duplicate package – View changed duplicate packages Warning Bundle introduced 9 new packages: define-data-property, es-define-property, es-errors and 6 more – View changed packages Bundle metrics
  
Bundle size by type
View job #11127 report View fix/eslint-version branch activity View project dashboard |
|
Performance test results: |
Rheeseyb
reviewed
Mar 18, 2024
|
Performance test results: |
|
Performance test results: |
seanparsons
approved these changes
Mar 19, 2024
|
Performance test results: |
|
Performance test results: |
|
Performance test results: |
|
Performance test results: |
Try me(deploying...) |
Try me(deploying...) |
Try me(deploying...) |
Try me(deploying...) |
Try me(deploying...) |
|
Temporarily closing as Spike |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
VSCode eslint didn't catch functions in
react/jsx-no-bindrule, whereas the prettier config did catch them.Fix:
eslint-plugin-react-*utopia-runtime-eslint- to fully separate it from our IDE lint config and plugins.This PR also fixes all of the new lint errors from this change.