Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: more api icons #5573

Merged
merged 6 commits into from
May 6, 2024
Merged

Chore: more api icons #5573

merged 6 commits into from
May 6, 2024

Conversation

balazsbajorics
Copy link
Contributor

Problem:
More icons that can be used as the ComponentToRegister.icon

Commit Details:

  • Malte added more options
  • now every icon option corresponds to an icon file, so there's no need for indirection in iconPropsForIcon
  • there were two iconPropsForIcons with a FIXME that one was the clone of the other, so I just deleted one

Copy link
Contributor

github-actions bot commented May 5, 2024

Try me

Copy link

relativeci bot commented May 5, 2024

#12263 Bundle Size — 62.48MiB (~-0.01%).

c1c2989(current) vs 6339ece master#12261(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#12263
     Baseline
#12261
Improvement  Initial JS 45.55MiB(~-0.01%) 45.55MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.99% 21.74%
No change  Chunks 31 31
No change  Assets 34 34
No change  Modules 4377 4377
No change  Duplicate Modules 504 504
No change  Duplicate Code 30.81% 30.81%
No change  Packages 468 468
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#12263
     Baseline
#12261
Improvement  JS 62.47MiB (~-0.01%) 62.47MiB
Improvement  HTML 10.94KiB (-0.34%) 10.98KiB

Bundle analysis reportBranch chore/more-api-iconsProject dashboard

Copy link
Contributor

github-actions bot commented May 5, 2024

Performance test results:
(Chart1)
(Chart2)

Copy link
Contributor

@Rheeseyb Rheeseyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many icons!

@balazsbajorics balazsbajorics merged commit 46b0146 into master May 6, 2024
16 checks passed
@balazsbajorics balazsbajorics deleted the chore/more-api-icons branch May 6, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants