Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data picker bug: overly strict type filtering #5979

Closed
balazsbajorics opened this issue Jun 18, 2024 · 0 comments · Fixed by #6028
Closed

Data picker bug: overly strict type filtering #5979

balazsbajorics opened this issue Jun 18, 2024 · 0 comments · Fixed by #6028
Assignees
@bkrmendy

Comments

@balazsbajorics
Copy link
Contributor

Image
@bkrmendy bkrmendy removed their assignment Jun 19, 2024
@bkrmendy bkrmendy self-assigned this Jul 1, 2024
@bkrmendy bkrmendy mentioned this issue Jul 1, 2024
Merged
@bkrmendy bkrmendy linked a pull request Jul 1, 2024 that will close this issue
Match numbers and string to element-valued properties #6028
Merged
bkrmendy added a commit that referenced this issue Jul 1, 2024
@bkrmendy
Match numbers and string to element-valued properties (#6028)
6a26bbc 
## Problem
If there's no annotation for a component property, we only treat JSX
elements as matching values for render props, even though strings and
numbers would be valid elements children as well.

## Fix
If we detect a render prop, the matching code treats strings and numbers
as matching as well.

#5979
liady pushed a commit that referenced this issue Dec 13, 2024
@bkrmendy @liady
Match numbers and string to element-valued properties (#6028)
6eeae52 
## Problem
If there's no annotation for a component property, we only treat JSX
elements as matching values for render props, even though strings and
numbers would be valid elements children as well.

## Fix
If we detect a render prop, the matching code treats strings and numbers
as matching as well.

#5979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkrmendy bkrmendy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Match numbers and string to element-valued properties concrete-utopia/utopia
2 participants
@balazsbajorics @bkrmendy