Navigate to the annotation in the sidecar file #5999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbalint
changed the title
#13142 Bundle Size — 62.25MiB (+0.02%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13142 |
Baseline #13140 |
|
|---|---|---|
 Initial JS |
45.32MiB(+0.02%) |
45.31MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
40.71% |
22.66% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4305(+0.07%) |
4302 |
| Duplicate Modules |
525(+0.38%) |
523 |
| Duplicate Code |
31.84% |
31.84% |
| Packages |
448 |
448 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13142 |
Baseline #13140 |
|
|---|---|---|
| JS |
62.24MiB (+0.02%) |
62.23MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch feature/navigate-to-annotation Project dashboard
gbalint
requested review from
seanparsons,
ruggi,
balazsbajorics,
liady and
bkrmendy
balazsbajorics
approved these changes
Jun 19, 2024
bkrmendy
approved these changes
Jun 19, 2024
2 tasks
gbalint
added a commit
that referenced
this pull request
Jun 20, 2024
**Problem:** Followup to #5999 3rd and 4th task of #5971 Added a new context menu item to the property control: you can directly navigate to the annotation of that specific property using the "Open <propertyname> annotation" menu item. **Commit Details:** (< vv pls delete this section if's not relevant) - Extended the component descriptor parser to process the individual properties too. - Extended the source representation of a descriptor to include bounds for the full annotation, and bounds for the individual properties too. - Extracting getting the component data in component-section into a hook, so I can use it from the individual controls to create to necessary context menu item. - I removed property name from the `unset` context menu item **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Preview mode Fixes #5971
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Followup to #5989 Clicking on the Components inspector section's ◇ logo opens the annotation file for the given component AND jumps to the annotation of the component in the file. (Second task of #5971 ) **Fix:** I used the Babel parser to find the component annotation in the sidecar file. - It can find the annotation if it in the exported object literal, or even if it is in a variable referred from this file. It does not support imports though, everything has to be in this file. - This is a best effort to find the annotation, if it can not do it like this (e.g. the annotation is dynamically generated, or anything which the parser is not prepared for), then it just doesn't save the bounds. Clicking on the button will still open the sidecar file. The bounds are stored in the component descriptor source object (which until now only stored the file path itself). **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Preview mode
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Followup to #5999 3rd and 4th task of #5971 Added a new context menu item to the property control: you can directly navigate to the annotation of that specific property using the "Open <propertyname> annotation" menu item. **Commit Details:** (< vv pls delete this section if's not relevant) - Extended the component descriptor parser to process the individual properties too. - Extended the source representation of a descriptor to include bounds for the full annotation, and bounds for the individual properties too. - Extracting getting the component data in component-section into a hook, so I can use it from the individual controls to create to necessary context menu item. - I removed property name from the `unset` context menu item **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Preview mode Fixes #5971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Followup to #5989
Clicking on the Components inspector section's ◇ logo opens the annotation file for the given component AND jumps to the annotation of the component in the file.
(Second task of #5971 )
Fix:
I used the Babel parser to find the component annotation in the sidecar file.
The bounds are stored in the component descriptor source object (which until now only stored the file path itself).
Manual Tests:
I hereby swear that: