Spike/grid controls #6027
Closed
Spike/grid controls #6027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13245 Bundle Size — 62.52MiB (+0.04%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13245 |
Baseline #13244 |
|
|---|---|---|
 Initial JS |
45.57MiB(+0.04%) |
45.55MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.6% |
23.8% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4323(+0.09%) |
4319 |
| Duplicate Modules |
525(+0.19%) |
524 |
| Duplicate Code |
31.75% |
31.75% |
| Packages |
450 |
450 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13245 |
Baseline #13244 |
|
|---|---|---|
| JS |
62.51MiB (+0.04%) |
62.48MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch spike/grid-controls Project dashboard
bkrmendy
commented
Jul 1, 2024
| ) | ||
| } | ||
| } | ||
| // if (foundTarget != null && draggingAllowed) { |
There was a problem hiding this comment.
we need to find out how to make this work
…to spike/grid-controls
2 tasks
bkrmendy
added a commit
that referenced
this pull request
Jul 1, 2024
Split out from #6027 ## Description This PR adds the `specialSizeMeasurements` fields we need to support the grid strategies from #6027. This PR doesn't add tests (beyond the snapshots), because this functionality will be tested through the strategies **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Preview mode
# Conflicts: # editor/src/components/canvas/dom-walker.ts # editor/src/components/inspector/common/css-utils.ts # editor/src/core/shared/element-template.ts
ruggi
added a commit
that referenced
this pull request
Jul 2, 2024
This is groundwork for #6027. The `Roll Your Own` floating thing made in the spike becomes a tab in the right pane (in the future we might want to have it as a floating panel, but we can incrementally extract it later on). The `Grid` section is left deliberately empty so we can fill it in with the other grid-related PRs. **Context/history** As part of the exploratory work on grid interactions (#6027) I added a way to test individual interaction/UI pieces in the spirit of [the classic Steve Jobs calculator story](https://www.reddit.com/r/mac/comments/o89l6i/the_apple_team_created_an_app_so_that_steve_jobs/) - called `Roll Your Own Grid` <img width="368" alt="Screenshot 2024-07-01 at 17 55 30" src="https://github.com/concrete-utopia/utopia/assets/1081051/c99a46a8-60ba-4a7c-ae03-ed4145ea7c3a"> There's a good chance this stuff will be useful for more than Grid in the future (e.g. the inspector, the canvas etc) so we can reuse this idea in other contexts, while keeping the original concept. **Note** The PR includes a demo feature type for `Grid` for illustration purposes only; it should be replaced with the actual features.
# Conflicts: # editor/src/utils/feature-switches.ts
…to spike/grid-controls
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
Split out from #6027 ## Description This PR adds the `specialSizeMeasurements` fields we need to support the grid strategies from #6027. This PR doesn't add tests (beyond the snapshots), because this functionality will be tested through the strategies **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Preview mode
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
This is groundwork for #6027. The `Roll Your Own` floating thing made in the spike becomes a tab in the right pane (in the future we might want to have it as a floating panel, but we can incrementally extract it later on). The `Grid` section is left deliberately empty so we can fill it in with the other grid-related PRs. **Context/history** As part of the exploratory work on grid interactions (#6027) I added a way to test individual interaction/UI pieces in the spirit of [the classic Steve Jobs calculator story](https://www.reddit.com/r/mac/comments/o89l6i/the_apple_team_created_an_app_so_that_steve_jobs/) - called `Roll Your Own Grid` <img width="368" alt="Screenshot 2024-07-01 at 17 55 30" src="https://github.com/concrete-utopia/utopia/assets/1081051/c99a46a8-60ba-4a7c-ae03-ed4145ea7c3a"> There's a good chance this stuff will be useful for more than Grid in the future (e.g. the inspector, the canvas etc) so we can reuse this idea in other contexts, while keeping the original concept. **Note** The PR includes a demo feature type for `Grid` for illustration purposes only; it should be replaced with the actual features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Utopia doesn't support grid layouts
Fix
Use the code we created during the hack days as a basis for supporting grids. This PR should be split into multiple smaller PRs, to me merged separately
TODO