Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid cleanup #6039

Merged
merged 7 commits into from
Jul 4, 2024
Merged

Grid cleanup #6039

merged 7 commits into from
Jul 4, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Jul 4, 2024

Problem:

The grid controls need cleaning up in multiple places.

Fix:

  1. As a followup to Remove TargetGridCell from grid move #6033, stop doing duplicate cell lookups in the controls mouse handler and instead rely on custom strategy state data about the target root cell
  2. Only trigger the shadow animation when the root cell changes (direct consequence of point 1)
  3. Fix duplicate keys for grid resize handlers inside flatMaps
  4. Remove a duplicate cell targets component which was a consequence of the spike code merges
  5. Use a helper for the grid cell targets instead of hardcoded gridcell- shenanigans

@ruggi ruggi changed the title Feat/grid cleanup Grid cleanup Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Try me

Copy link

relativeci bot commented Jul 4, 2024

#13262 Bundle Size — 62.51MiB (~-0.01%).

628c286(current) vs 6339ece master#13256(baseline)

Warning

Bundle contains 51 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Improvement 1 improvement
                 Current
#13262
     Baseline
#13256
Improvement  Initial JS 45.56MiB(~-0.01%) 45.56MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.85% 21.6%
No change  Chunks 30 30
No change  Assets 33 33
Change  Modules 4323(+0.02%) 4322
No change  Duplicate Modules 524 524
No change  Duplicate Code 31.74% 31.74%
No change  Packages 450 450
No change  Duplicate Packages 51 51
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#13262
     Baseline
#13256
Improvement  JS 62.5MiB (~-0.01%) 62.5MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch feat/grid-cleanupProject dashboard

@ruggi ruggi merged commit ec8f2c0 into master Jul 4, 2024
13 checks passed
@ruggi ruggi deleted the feat/grid-cleanup branch July 4, 2024 15:53
liady pushed a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants