Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot resize grid rows/cols that don't match the template #6071

Closed
ruggi opened this issue Jul 12, 2024 · 0 comments · Fixed by #6072
Closed

Cannot resize grid rows/cols that don't match the template #6071

ruggi opened this issue Jul 12, 2024 · 0 comments · Fixed by #6072
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Jul 12, 2024

No description provided.

@ruggi ruggi self-assigned this Jul 12, 2024
@ruggi ruggi added Canvas Affects the visual editor and removed Canvas Affects the visual editor labels Jul 12, 2024
@ruggi ruggi mentioned this issue Jul 12, 2024
Merged
ruggi added a commit that referenced this issue Jul 12, 2024
@ruggi
Fix resizing grid for extra cells (#6072)
91a17fa 
**Problem:**

If a grid contains more cell elements than what's declared in the grid
template, the grid resize stops working for the overflowing
rows/columns.

For example, try to resize the last column in this grid
https://utopia.fish/p/c6133e47-eight-cork

**Fix:**

1. Do not rely on the gird template from props but only the calculated
grid values, which are the same used in the other grid strategies (e.g.
to display the grid shadows)
2. For now, just stick to converting everything to calculated units
(e.g. resizing a `fr` unit will transform the template to `px`) - I
think it's ok for now until we decide how to tackle those cases, and we
have to deal with simpler code in the meantime
3. When the grid is resized, apply the new "fixed" templates too (so if
you have an actual grid that contradicts the template, update the
template accordingly).

Fix #6071
liady pushed a commit that referenced this issue Dec 13, 2024
@ruggi @liady
Fix resizing grid for extra cells (#6072)
d16ddd9 
**Problem:**

If a grid contains more cell elements than what's declared in the grid
template, the grid resize stops working for the overflowing
rows/columns.

For example, try to resize the last column in this grid
https://utopia.fish/p/c6133e47-eight-cork

**Fix:**

1. Do not rely on the gird template from props but only the calculated
grid values, which are the same used in the other grid strategies (e.g.
to display the grid shadows)
2. For now, just stick to converting everything to calculated units
(e.g. resizing a `fr` unit will transform the template to `px`) - I
think it's ok for now until we decide how to tackle those cases, and we
have to deal with simpler code in the meantime
3. When the grid is resized, apply the new "fixed" templates too (so if
you have an actual grid that contradicts the template, update the
template accordingly).

Fix #6071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix resizing grid for extra cells concrete-utopia/utopia
1 participant
@ruggi