Fix resizing grid for extra cells #6072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13359 Bundle Size — 62.64MiB (-0.02%).
Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13359 |
Baseline #13355 |
|
|---|---|---|
 Initial JS |
45.71MiB(~+0.01%) |
45.71MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
19.25% |
21.6% |
| Chunks |
31(+3.33%) |
30 |
| Assets |
34(+3.03%) |
33 |
| Modules |
4371(-0.07%) |
4374 |
 Duplicate Modules |
521(-0.57%) |
524 |
| Duplicate Code |
31.68%(-0.06%) |
31.7% |
| Packages |
469 |
469 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 2 improvements
| Current #13359 |
Baseline #13355 |
|
|---|---|---|
| JS |
62.63MiB (-0.02%) |
62.65MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch fix/resize-grid-extra-cells Project dashboard
seanparsons
approved these changes
Jul 12, 2024
seanparsons
approved these changes
Jul 12, 2024
Rheeseyb
approved these changes
Jul 12, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** If a grid contains more cell elements than what's declared in the grid template, the grid resize stops working for the overflowing rows/columns. For example, try to resize the last column in this grid https://utopia.fish/p/c6133e47-eight-cork **Fix:** 1. Do not rely on the gird template from props but only the calculated grid values, which are the same used in the other grid strategies (e.g. to display the grid shadows) 2. For now, just stick to converting everything to calculated units (e.g. resizing a `fr` unit will transform the template to `px`) - I think it's ok for now until we decide how to tackle those cases, and we have to deal with simpler code in the meantime 3. When the grid is resized, apply the new "fixed" templates too (so if you have an actual grid that contradicts the template, update the template accordingly). Fix #6071
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
If a grid contains more cell elements than what's declared in the grid template, the grid resize stops working for the overflowing rows/columns.
For example, try to resize the last column in this grid https://utopia.fish/p/c6133e47-eight-cork
Fix:
frunit will transform the template topx) - I think it's ok for now until we decide how to tackle those cases, and we have to deal with simpler code in the meantimeFix #6071