Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid template parsing should support labels #6079

Closed
ruggi opened this issue Jul 15, 2024 · 0 comments · Fixed by #6080
Closed

Grid template parsing should support labels #6079

ruggi opened this issue Jul 15, 2024 · 0 comments · Fixed by #6080
Assignees

Comments

@ruggi
Copy link
Contributor

ruggi commented Jul 15, 2024

No description provided.

@ruggi ruggi self-assigned this Jul 15, 2024
ruggi added a commit that referenced this issue Jul 15, 2024
**Problem:**

Parsed CSS grid templates should support area names.

**Fix:**

Parse area names along with the CSS number for grid templates. The label
is stored in the number itself, so we can reuse it later (e.g. for
targeting via other style props).

To make it more apparent, I added the area name under the resize
handles, but it's definitely not a requirement (although I think it
could/should be shown somewhere!).


https://github.com/user-attachments/assets/5aba975d-3b24-48be-8d69-c19f774bb351


Fixes #6079
liady pushed a commit that referenced this issue Dec 13, 2024
**Problem:**

Parsed CSS grid templates should support area names.

**Fix:**

Parse area names along with the CSS number for grid templates. The label
is stored in the number itself, so we can reuse it later (e.g. for
targeting via other style props).

To make it more apparent, I added the area name under the resize
handles, but it's definitely not a requirement (although I think it
could/should be shown somewhere!).


https://github.com/user-attachments/assets/5aba975d-3b24-48be-8d69-c19f774bb351


Fixes #6079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant