Support area names in grid templates #6080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkrmendy
approved these changes
Jul 15, 2024
#13377 Bundle Size — 62.65MiB (~+0.01%).
Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13377 |
Baseline #13369 |
|
|---|---|---|
 Initial JS |
45.72MiB(~+0.01%) |
45.72MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
22.22% |
21.55% |
| Chunks |
31 |
31 |
| Assets |
34 |
34 |
| Modules |
4371 |
4371 |
| Duplicate Modules |
521 |
521 |
| Duplicate Code |
31.68% |
31.68% |
| Packages |
469 |
469 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13377 |
Baseline #13369 |
|
|---|---|---|
| JS |
62.64MiB (~+0.01%) |
62.63MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch feat/grid-template-labels Project dashboard
liady
reviewed
Jul 15, 2024
liady
approved these changes
Jul 15, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Parsed CSS grid templates should support area names. **Fix:** Parse area names along with the CSS number for grid templates. The label is stored in the number itself, so we can reuse it later (e.g. for targeting via other style props). To make it more apparent, I added the area name under the resize handles, but it's definitely not a requirement (although I think it could/should be shown somewhere!). https://github.com/user-attachments/assets/5aba975d-3b24-48be-8d69-c19f774bb351 Fixes #6079
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Parsed CSS grid templates should support area names.
Fix:
Parse area names along with the CSS number for grid templates. The label is stored in the number itself, so we can reuse it later (e.g. for targeting via other style props).
To make it more apparent, I added the area name under the resize handles, but it's definitely not a requirement (although I think it could/should be shown somewhere!).
Screen.Recording.2024-07-15.at.15.08.01.mov
Fixes #6079