Support repeat() in grid templates
#6090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liady
reviewed
Jul 17, 2024
| @@ -943,11 +943,35 @@ export function parseGridRange( | |||
| } | |||
| } | |||
|
|
|||
| // this regex matches 'repeat ( [unit] , [value] )', capturing groups around the unit (1) and the value (2) | |||
| const reRepeatFunction = /repeat\s*\(\s*(\d+)\s*,\s*([^,\)]+)\s*\)/ | |||
There was a problem hiding this comment.
just a note - maybe add a TODO to support non-units repeaters (i.e auto-fit, auto-fill, etc)
#13416 Bundle Size — 62.63MiB (-0.05%).
Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13416 |
Baseline #13413 |
|
|---|---|---|
 Initial JS |
45.7MiB(-0.07%) |
45.73MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
26.47% |
21.56% |
| Chunks |
31 |
31 |
| Assets |
34 |
34 |
| Modules |
4374(+0.07%) |
4371 |
 Duplicate Modules |
523(+0.38%) |
521 |
| Duplicate Code |
31.69%(+0.03%) |
31.68% |
| Packages |
469 |
469 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 2 improvements
| Current #13416 |
Baseline #13413 |
|
|---|---|---|
| JS |
62.62MiB (-0.05%) |
62.65MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch feat/grid-template-repeat Project dashboard
bkrmendy
approved these changes
Jul 18, 2024
seanparsons
approved these changes
Jul 18, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Grids with `repeat()` in their template are correctly displayed, but cannot be resized because the dimensions are `FALLBACK`. **Fix:** Expand the `repeat()` functions inside the templates when parsing them, so they are calculated correctly. https://github.com/user-attachments/assets/7744262c-f701-4685-a357-6ddaf9685bca Fixes #6089
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Grids with
repeat()in their template are correctly displayed, but cannot be resized because the dimensions areFALLBACK.Fix:
Expand the
repeat()functions inside the templates when parsing them, so they are calculated correctly.Screen.Recording.2024-07-17.at.12.10.05.mov
Fixes #6089