Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(404): fix empty email when the field is empty #6095

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix(404): fix empty email when the field is empty #6095

merged 1 commit into from
Jul 18, 2024

Conversation

liady
Copy link
Contributor

@liady liady commented Jul 17, 2024

Problem:
Currently we show a broken string when the user has no email field
image

Fix:
In case the email field is missing - don't show the string at all (no value in it)
image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jul 17, 2024

#13409 Bundle Size — 62.66MiB (~-0.01%).

5a4c3bf(current) vs 6339ece master#13403(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#13409		      Baseline
#13403
Regression  Initial JS 45.73MiB(~+0.01%) 45.73MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.58% 21.56%
No change  Chunks 31 31
No change  Assets 34 34
No change  Modules 4371 4371
No change  Duplicate Modules 521 521
No change  Duplicate Code 31.68% 31.68%
No change  Packages 469 469
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13409		      Baseline
#13403
Regression  JS 62.65MiB (~+0.01%) 62.65MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis report Branch fix/empty-email Project dashboard

@liady liady merged commit 6b55a91 into master Jul 18, 2024
18 checks passed
@liady liady deleted the fix/empty-email branch July 18, 2024 10:09
liady added a commit that referenced this pull request Dec 13, 2024
@liady
fix(404): fix empty email when the field is empty (#6095)
8fe8ca5 
**Problem:**
Currently we show a broken string when the user has no email field

![image](https://github.com/user-attachments/assets/08beb561-c7c5-4274-a240-95599d541719)


**Fix:**
In case the email field is missing - don't show the string at all (no
value in it)

![image](https://github.com/user-attachments/assets/29ef9718-3acf-4f48-a73c-302316055b55)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lankaukk lankaukk lankaukk approved these changes

@bkrmendy bkrmendy bkrmendy approved these changes

@balazsbajorics balazsbajorics balazsbajorics approved these changes

@gbalint gbalint gbalint approved these changes

@ruggi ruggi Awaiting requested review from ruggi

@seanparsons seanparsons Awaiting requested review from seanparsons

@Rheeseyb Rheeseyb Awaiting requested review from Rheeseyb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liady @gbalint @balazsbajorics @bkrmendy @lankaukk