Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"No default available" can appear in the strategy picker alone #6100

Closed
gbalint opened this issue Jul 18, 2024 · 0 comments · Fixed by #6108
Closed

"No default available" can appear in the strategy picker alone #6100

gbalint opened this issue Jul 18, 2024 · 0 comments · Fixed by #6108
Assignees
@gbalint

Comments

@gbalint
Copy link
Contributor

gbalint commented Jul 18, 2024

Even though that is not functionally different from an empty strategy picker.
See e.g. https://screenshot.click/09-58-2y0j3-u5kri.mp4
@gbalint gbalint self-assigned this Jul 18, 2024
@gbalint gbalint mentioned this issue Jul 23, 2024
Merged
2 tasks
gbalint added a commit that referenced this issue Jul 24, 2024
@gbalint
Improve experience when no strategy is applicable (#6108)
1789889 
**Problem:**
The original issue is described in this issue:
#6100
However, the problem is not really that the do nothing strategy can
appear alone, but more about the confusing experience when no strategies
are applicable.

**Fix:**
- When there is no applicable strategy with fitness>0, we should always
insert Do nothing to have a single strategy.
- However, the do nothing strategy is an implementation detail, we
should not expose it to the users. The strategy indicator and the
strategy picker should not be shown when that is the only strategy.
- The NotPermitted cursor should be shown when do nothing is the active
strategy, to express that nothing will happen in this interaction.
- Do nothing strategy should never be used as an ancestor strategy, it
just doesn't make sense (it doesn't matter what do you do nothing with)

**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Preview mode

Fixes #6100
liady pushed a commit that referenced this issue Dec 13, 2024
@gbalint @liady
Improve experience when no strategy is applicable (#6108)
3f767e3 
**Problem:**
The original issue is described in this issue:
#6100
However, the problem is not really that the do nothing strategy can
appear alone, but more about the confusing experience when no strategies
are applicable.

**Fix:**
- When there is no applicable strategy with fitness>0, we should always
insert Do nothing to have a single strategy.
- However, the do nothing strategy is an implementation detail, we
should not expose it to the users. The strategy indicator and the
strategy picker should not be shown when that is the only strategy.
- The NotPermitted cursor should be shown when do nothing is the active
strategy, to express that nothing will happen in this interaction.
- Do nothing strategy should never be used as an ancestor strategy, it
just doesn't make sense (it doesn't matter what do you do nothing with)

**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Preview mode

Fixes #6100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbalint gbalint

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve experience when no strategy is applicable concrete-utopia/utopia
1 participant
@gbalint