New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grid draw to insert when TL of the drag origin #6369

Closed

ruggi opened this issue Sep 13, 2024 · 0 comments · Fixed by #6370

Assignees

Contributor

ruggi commented Sep 13, 2024

No description provided.

ruggi self-assigned this

ruggi mentioned this issue

Fix draw-to-insert into grid when going top-left of the origin #6370

Merged

ruggi closed this as completed in #6370

ruggi added a commit that referenced this issue


          Fix draw-to-insert into grid when going top-left of the origin (#6370)

1798bb8

**Problem:**

Draw-to-insert into a grid does not work if the drag vector goes
top/left of the drag origin.

**Fix:**

Fix the origin calculation.
Also, I added a TODO in the code to improve this strategy in an
incremental PR.

| Before | After |
|-------|---------|
| ![Kapture 2024-09-13 at 17 40
56](https://github.com/user-attachments/assets/218fb02c-4e6e-476f-9376-c7a963598959)
| ![Kapture 2024-09-13 at 17 40
06](https://github.com/user-attachments/assets/9187b0bb-9c79-4859-93f4-168061da8de5)
|

Fixes #6369

liady pushed a commit that referenced this issue


          Fix draw-to-insert into grid when going top-left of the origin (#6370)

fbd735c

**Problem:**

Draw-to-insert into a grid does not work if the drag vector goes
top/left of the drag origin.

**Fix:**

Fix the origin calculation.
Also, I added a TODO in the code to improve this strategy in an
incremental PR.

| Before | After |
|-------|---------|
| ![Kapture 2024-09-13 at 17 40
56](https://github.com/user-attachments/assets/218fb02c-4e6e-476f-9376-c7a963598959)
| ![Kapture 2024-09-13 at 17 40
06](https://github.com/user-attachments/assets/9187b0bb-9c79-4859-93f4-168061da8de5)
|

Fixes #6369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment