Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep repeats when editing grid templates via the inspector #6387

Closed
ruggi opened this issue Sep 18, 2024 · 0 comments · Fixed by #6388
Closed

Keep repeats when editing grid templates via the inspector #6387

ruggi opened this issue Sep 18, 2024 · 0 comments · Fixed by #6388
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Sep 18, 2024

No description provided.

@ruggi ruggi self-assigned this Sep 18, 2024
@ruggi ruggi mentioned this issue Sep 18, 2024
Merged
@ruggi ruggi closed this as completed in 96795b0 Sep 19, 2024
liady pushed a commit that referenced this issue Dec 13, 2024
@ruggi @liady
Grids: presetve repeat from inspector changes (#6388)
75eed03 
**Problem:**

As a followup to #6380 , we should preserve `repeat` functions & co.
when altering the grid template from the inspector inputs too.

**Fix:**

1. Factored out the logic to alter a table from the resize strategy to
helper functions in `grid-helpers.ts`
2. Adjusted the logic to support removing elements too
3. Refactored the callbacks in the inspector section to use the new
helpers

Fixes #6387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Grids: presetve repeat from inspector changes concrete-utopia/utopia
1 participant
@ruggi