Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse grid span #6628

Closed
ruggi opened this issue Nov 11, 2024 · 0 comments · Fixed by #6629
Closed

parse grid span #6628

ruggi opened this issue Nov 11, 2024 · 0 comments · Fixed by #6629
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Nov 11, 2024

No description provided.

@ruggi ruggi self-assigned this Nov 11, 2024
@ruggi ruggi mentioned this issue Nov 11, 2024
Merged
@ruggi ruggi closed this as completed in 2daa9a7 Nov 12, 2024
liady pushed a commit that referenced this issue Dec 13, 2024
@ruggi @liady
Parse grid spans, use csstree for placement parsing (#6629)
71e1d90 
**Problem:**

1. Parsing an element placing does not use `csstree`
2. Spans are not parsed nor represented

This is a purely-parsing PR, laying the groundwork to have strategies
and interactions play nicely with spanning items.

**Fix:**

1. Use `csstree` to parse grid placement
2. Parse `span` coming form parsing props

Fixes #6628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parse grid spans, use csstree for placement parsing concrete-utopia/utopia
1 participant
@ruggi