Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer spans when resizing flow grid cells #6686

Closed
ruggi opened this issue Nov 27, 2024 · 0 comments · Fixed by #6687
Closed

Prefer spans when resizing flow grid cells #6686

ruggi opened this issue Nov 27, 2024 · 0 comments · Fixed by #6687
Assignees

Comments

@ruggi
Copy link
Contributor

ruggi commented Nov 27, 2024

No description provided.

@ruggi ruggi self-assigned this Nov 27, 2024
@ruggi ruggi closed this as completed in bdbc857 Nov 28, 2024
liady pushed a commit that referenced this issue Dec 13, 2024
**Problem:**

When resizing a grid cell for an in-flow element, `span` notation should
be prefered over explicit pins.

**Fix:**

If the resize happens on a right/bottom edge and the element is in flow,
apply the `span` notation.

**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Play mode

Fixes #6686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant