Use pink from the light theme for grid controls accents #6708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanparsons
approved these changes
Dec 6, 2024
bkrmendy
approved these changes
Dec 6, 2024
liady
approved these changes
Dec 6, 2024
#15381 Bundle Size — 58.21MiB (~+0.01%).d86257c(current) vs d1d46c1 master#15380(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #15381 |
Baseline #15380 |
|
|---|---|---|
 Initial JS |
41.18MiB(~+0.01%) |
41.18MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.24% |
18.12% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4189 |
4189 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.24% |
27.24% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #15381 |
Baseline #15380 |
|
|---|---|---|
| JS |
58.2MiB (~+0.01%) |
58.2MiB |
| HTML |
9.4KiB (-0.21%) |
9.42KiB |
Bundle analysis report Branch fix/ruler-marker-light-pink Project dashboard
Generated by RelativeCI Documentation Report issue
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** The pink/magenta color used in the grid controls should always be the one from the light theme. **Fix:** Use a new `gridControlsPink` color that matches `brandNeonPink` from the light theme. Fixes #6707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The pink/magenta color used in the grid controls should always be the one from the light theme.
Fix:
Use a new
gridControlsPinkcolor that matchesbrandNeonPinkfrom the light theme.Fixes #6707