Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to make jest run tests faster. #6709

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

seanparsons
Copy link
Contributor

@seanparsons seanparsons commented Dec 8, 2024

Problem:
Jest tests are a little slow overall.

Fix:
Slightly rejigged some parser tests to not have one really long running test file, because Jest parallelises at the file level.

Commit Details:

  • Moved a UIDs related test into parser-printer-uids.spec.tsx.
  • Reduced the maxRuns for the moved test as it was taking a long time.

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

Copy link
Contributor

github-actions bot commented Dec 8, 2024

Try me

Copy link

relativeci bot commented Dec 8, 2024

#15383 Bundle Size — 58.21MiB (~-0.01%).

23ec4fa(current) vs d1d46c1 master#15382(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#15383
     Baseline
#15382
Regression  Initial JS 41.18MiB(~+0.01%) 41.18MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.24% 18.12%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4189 4189
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.24% 27.24%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#15383
     Baseline
#15382
Regression  JS 58.2MiB (~+0.01%) 58.2MiB
Improvement  HTML 9.4KiB (-0.21%) 9.42KiB

Bundle analysis reportBranch performance/faster-jest-runsProject dashboard


Generated by RelativeCIDocumentationReport issue

@seanparsons seanparsons marked this pull request as ready for review December 9, 2024 11:05
@seanparsons seanparsons merged commit d258bcf into master Dec 9, 2024
17 checks passed
@seanparsons seanparsons deleted the performance/faster-jest-runs branch December 9, 2024 14:37
liady pushed a commit that referenced this pull request Dec 13, 2024
- Moved a UIDs related test into `parser-printer-uids.spec.tsx`.
- Reduced the `maxRuns` for the moved test as it was taking a long time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants