Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin OpenMM version >=7.3.1,<7.6 #9

Closed
mjw99 opened this issue Dec 13, 2021 · 9 comments
Closed

Pin OpenMM version >=7.3.1,<7.6 #9

mjw99 opened this issue Dec 13, 2021 · 9 comments
Assignees

Comments

@mjw99
Copy link

mjw99 commented Dec 13, 2021

Due to a recent top level Python package rename in OpenMM 7.6, some modules will no longer be found. I think this is the correct syntax:

    - openmm >=7.3.1,<7.6

See also:
choderalab/yank#1260
choderalab/yank#1261

@jchodera
Copy link

@ijpulidos @mikemhenry : If these are really fatal errors rather than just warnings, we should focus on getting updated bugfix releases out of these packages (yank, openmmtools) that fix the imports. Can you help here?

In the meantime, it does sound reasonable to pin the useful versions of these to openmm<7.6 (as @mjw99 suggests) if these are indeed errors and not warnings.

@mikemhenry
Copy link
Contributor

I will investigate! I thought we fixed things in a backwards compatible way with the new namespace changes

@mikemhenry mikemhenry self-assigned this Dec 13, 2021
@mikemhenry
Copy link
Contributor

This was fixed in choderalab/openmmtools#528 so we just need to cut a new release

@mikemhenry
Copy link
Contributor

Plan is to push out a bug fix release, then once openmm 7.7 is out, we will bump the build number and prevent openmm 7.6 being pulled in which we know has issues: openmm/openmm#3310

@mjw99
Copy link
Author

mjw99 commented Dec 13, 2021

Many thanks for your help Mike!

@mikemhenry
Copy link
Contributor

@mjw99 Just wanted to give you an update, we are working on a blocking issue here choderalab/openmmtools#538 and once we get that merged, we will be cutting a new release that will fix this. Thank you for your patience.

@ijpulidos
Copy link
Contributor

Yes, as Mike says we are currently working on solving the critical issues with how ContextCache is being used and getting very close to gettting something completed.

My opinion on this one is that we should pin to versions equal or larger than the minimum version we aim to support from OpenMM or not pinning at all (just openmm). I think this is what has less issues for future releases of the dependencies.

@mjw99
Copy link
Author

mjw99 commented Jan 21, 2022

Dear @mikemhenry and @ijpulidos,
I really appreciate all your hard work here and the updates.

Many thanks,

Mark

@jchodera
Copy link

This should be resolved now with the release of OpenMM 7.7. Many apologies we were unable to resolve this earlier---we still don't have sufficient resources to officially support YANK at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants