Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISS verifies signers of checkpoint message with info from checkpoint message #397

Closed
ranchalp opened this issue Apr 10, 2023 · 1 comment
Closed

ISS verifies signers of checkpoint message with info from checkpoint message #397

ranchalp opened this issue Apr 10, 2023 · 1 comment
Labels
bug Something isn't working cleanup M2

Comments

@ranchalp
Copy link
Contributor

As noted in the code already:

// TODO: Technically this is wrong.
	//       The memberhips information in the checkpint is used to verify the checkpoint itself.
	//       This makes it possible to construct an arbitrary valid checkpoint.
	//       Use an independent local source of memberhip information instead.

Making this placeholder in order to fix it for M2.
@ranchalp ranchalp added bug Something isn't working cleanup labels Apr 10, 2023
@jsoares jsoares added the M2 label Apr 17, 2023
@matejpavlovic
Copy link
Contributor

@ranchalp is this a duplicate of #402 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cleanup M2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsoares @ranchalp @matejpavlovic