Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ApiErrorId with Uuid #21

Open
coord-e opened this issue Jan 17, 2021 · 0 comments
Open

Implement ApiErrorId with Uuid #21

coord-e opened this issue Jan 17, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone
0.4.0

Comments

@coord-e
Copy link
Owner

coord-e commented Jan 17, 2021

ApiErrorId is just a newtype of String.

misskey-rs/misskey-core/src/model.rs

Line 13 in 273c28a

pub struct ApiErrorId(pub String);

However, it seems that Misskey's error ID is actually a UUID.
Implementing ApiErrorID with Uuid has a big advantage, especially in terms of the ability to create constants.
It would be very useful to have known error IDs as constants.

Unresolved questions

  • Are all Misskey's error IDs UUID?
  • Where to implement error ID constants?
@coord-e coord-e added the enhancement New feature or request label Jan 17, 2021
@coord-e coord-e added this to the 0.3.0 milestone Jan 21, 2021
@coord-e coord-e modified the milestones: 0.3.0, 0.4.0 May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
1 participant
@coord-e